clippy: fix warnings

This commit is contained in:
Valentin Tolmer 2021-05-14 09:28:15 +02:00
parent e0bcb58d36
commit e524fb0f55
3 changed files with 15 additions and 9 deletions

View File

@ -10,7 +10,8 @@ pub struct LoginForm {
on_logged_in: Callback<String>, on_logged_in: Callback<String>,
error: Option<anyhow::Error>, error: Option<anyhow::Error>,
node_ref: NodeRef, node_ref: NodeRef,
task: Option<FetchTask>, // Used to keep the request alive long enough.
_task: Option<FetchTask>,
} }
#[derive(Clone, PartialEq, Properties)] #[derive(Clone, PartialEq, Properties)]
@ -33,7 +34,7 @@ impl Component for LoginForm {
on_logged_in: props.on_logged_in, on_logged_in: props.on_logged_in,
error: None, error: None,
node_ref: NodeRef::default(), node_ref: NodeRef::default(),
task: None, _task: None,
} }
} }
@ -61,7 +62,7 @@ impl Component for LoginForm {
req, req,
self.link.callback(Msg::AuthenticationResponse), self.link.callback(Msg::AuthenticationResponse),
) { ) {
Ok(task) => self.task = Some(task), Ok(task) => self._task = Some(task),
Err(e) => self.error = Some(e), Err(e) => self.error = Some(e),
} }
} }

View File

@ -7,8 +7,9 @@ use yew::services::{fetch::FetchTask, ConsoleService};
pub struct UserTable { pub struct UserTable {
link: ComponentLink<Self>, link: ComponentLink<Self>,
task: Option<FetchTask>,
users: Option<Result<Vec<User>>>, users: Option<Result<Vec<User>>>,
// Used to keep the request alive long enough.
_task: Option<FetchTask>,
} }
pub enum Msg { pub enum Msg {
@ -18,9 +19,9 @@ pub enum Msg {
impl UserTable { impl UserTable {
fn get_users(&mut self, req: ListUsersRequest) { fn get_users(&mut self, req: ListUsersRequest) {
match HostService::list_users(req, self.link.callback(Msg::ListUsersResponse)) { match HostService::list_users(req, self.link.callback(Msg::ListUsersResponse)) {
Ok(task) => self.task = Some(task), Ok(task) => self._task = Some(task),
Err(e) => { Err(e) => {
self.task = None; self._task = None;
ConsoleService::log(format!("Error trying to fetch users: {}", e).as_str()) ConsoleService::log(format!("Error trying to fetch users: {}", e).as_str())
} }
}; };
@ -34,7 +35,7 @@ impl Component for UserTable {
fn create(_: Self::Properties, link: ComponentLink<Self>) -> Self { fn create(_: Self::Properties, link: ComponentLink<Self>) -> Self {
let mut table = UserTable { let mut table = UserTable {
link: link.clone(), link: link.clone(),
task: None, _task: None,
users: None, users: None,
}; };
table.get_users(ListUsersRequest { filters: None }); table.get_users(ListUsersRequest { filters: None });

View File

@ -211,7 +211,6 @@ pub fn build_tcp_server<Backend>(
where where
Backend: BackendHandler + 'static, Backend: BackendHandler + 'static,
{ {
let http_port = config.http_port.clone();
let jwt_secret = config.jwt_secret.clone(); let jwt_secret = config.jwt_secret.clone();
server_builder server_builder
.bind("http", ("0.0.0.0", config.http_port), move || { .bind("http", ("0.0.0.0", config.http_port), move || {
@ -224,5 +223,10 @@ where
)) ))
.tcp() .tcp()
}) })
.with_context(|| format!("While bringing up the TCP server with port {}", http_port)) .with_context(|| {
format!(
"While bringing up the TCP server with port {}",
config.http_port
)
})
} }