Remove useless clones

This commit is contained in:
Valentin Tolmer 2021-06-30 21:05:08 +02:00 committed by nitnelave
parent 5a3332430f
commit c7fb8baadb
2 changed files with 13 additions and 9 deletions

View File

@ -175,7 +175,7 @@ where
Backend: OpaqueHandler + 'static, Backend: OpaqueHandler + 'static,
{ {
data.backend_handler data.backend_handler
.login_start(request.clone()) .login_start(request.into_inner())
.await .await
.map(|res| ApiResult::Left(web::Json(res))) .map(|res| ApiResult::Left(web::Json(res)))
.unwrap_or_else(error_to_api_response) .unwrap_or_else(error_to_api_response)
@ -225,7 +225,11 @@ async fn opaque_login_finish<Backend>(
where where
Backend: TcpBackendHandler + BackendHandler + OpaqueHandler + 'static, Backend: TcpBackendHandler + BackendHandler + OpaqueHandler + 'static,
{ {
let name = match data.backend_handler.login_finish(request.clone()).await { let name = match data
.backend_handler
.login_finish(request.into_inner())
.await
{
Ok(n) => n, Ok(n) => n,
Err(e) => return error_to_http_response(e), Err(e) => return error_to_http_response(e),
}; };
@ -239,10 +243,11 @@ async fn post_authorize<Backend>(
where where
Backend: TcpBackendHandler + BackendHandler + LoginHandler + 'static, Backend: TcpBackendHandler + BackendHandler + LoginHandler + 'static,
{ {
if let Err(e) = data.backend_handler.bind(request.clone()).await { let name = request.name.clone();
if let Err(e) = data.backend_handler.bind(request.into_inner()).await {
return error_to_http_response(e); return error_to_http_response(e);
} }
get_login_successful_response(&data, &request.name).await get_login_successful_response(&data, &name).await
} }
async fn opaque_register_start<Backend>( async fn opaque_register_start<Backend>(
@ -253,7 +258,7 @@ where
Backend: OpaqueHandler + 'static, Backend: OpaqueHandler + 'static,
{ {
data.backend_handler data.backend_handler
.registration_start(request.clone()) .registration_start(request.into_inner())
.await .await
.map(|res| ApiResult::Left(web::Json(res))) .map(|res| ApiResult::Left(web::Json(res)))
.unwrap_or_else(error_to_api_response) .unwrap_or_else(error_to_api_response)
@ -268,7 +273,7 @@ where
{ {
if let Err(e) = data if let Err(e) = data
.backend_handler .backend_handler
.registration_finish(request.clone()) .registration_finish(request.into_inner())
.await .await
{ {
return error_to_http_response(e); return error_to_http_response(e);

View File

@ -20,9 +20,8 @@ async fn user_list_handler<Backend>(
where where
Backend: TcpBackendHandler + BackendHandler + 'static, Backend: TcpBackendHandler + BackendHandler + 'static,
{ {
let req: ListUsersRequest = info.clone();
data.backend_handler data.backend_handler
.list_users(req) .list_users(info.into_inner())
.await .await
.map(|res| ApiResult::Left(web::Json(res))) .map(|res| ApiResult::Left(web::Json(res)))
.unwrap_or_else(error_to_api_response) .unwrap_or_else(error_to_api_response)
@ -53,7 +52,7 @@ where
Backend: TcpBackendHandler + BackendHandler + 'static, Backend: TcpBackendHandler + BackendHandler + 'static,
{ {
data.backend_handler data.backend_handler
.create_user(info.clone()) .create_user(info.into_inner())
.await .await
.map(|res| ApiResult::Left(web::Json(res))) .map(|res| ApiResult::Left(web::Json(res)))
.unwrap_or_else(error_to_api_response) .unwrap_or_else(error_to_api_response)