diff --git a/app/src/components/app.rs b/app/src/components/app.rs index a41346f..e20fed7 100644 --- a/app/src/components/app.rs +++ b/app/src/components/app.rs @@ -32,7 +32,7 @@ pub struct App { user_info: Option<(String, bool)>, redirect_to: Option, route_dispatcher: RouteAgentDispatcher, - password_reset_enabled: bool, + password_reset_enabled: Option, task: Option, } @@ -64,7 +64,7 @@ impl Component for App { }), redirect_to: Self::get_redirect_route(), route_dispatcher: RouteAgentDispatcher::new(), - password_reset_enabled: false, + password_reset_enabled: None, task: None, }; app.task = Some( @@ -95,22 +95,21 @@ impl Component for App { Msg::Logout => { self.user_info = None; self.redirect_to = None; + self.route_dispatcher + .send(RouteRequest::ReplaceRoute(Route::from(AppRoute::Login))); } Msg::PasswordResetProbeFinished(Ok(enabled)) => { self.task = None; - self.password_reset_enabled = enabled; + self.password_reset_enabled = Some(enabled); } Msg::PasswordResetProbeFinished(Err(err)) => { self.task = None; + self.password_reset_enabled = Some(false); ConsoleService::error(&format!( "Could not probe for password reset support: {err:#}" )); } } - if self.user_info.is_none() { - self.route_dispatcher - .send(RouteRequest::ReplaceRoute(Route::from(AppRoute::Login))); - } true } @@ -160,7 +159,7 @@ impl App { let route_service = RouteService::<()>::new(); let current_route = route_service.get_path(); if current_route.contains("reset-password") { - if !self.password_reset_enabled { + if self.password_reset_enabled == Some(false) { self.route_dispatcher .send(RouteRequest::ReplaceRoute(Route::from(AppRoute::Login))); } @@ -195,11 +194,11 @@ impl App { switch: AppRoute, link: &ComponentLink, is_admin: bool, - password_reset_enabled: bool, + password_reset_enabled: Option, ) -> Html { match switch { AppRoute::Login => html! { - + }, AppRoute::CreateUser => html! { @@ -234,23 +233,20 @@ impl App { AppRoute::ChangePassword(username) => html! { }, - AppRoute::StartResetPassword => { - if password_reset_enabled { - html! { - - } - } else { + AppRoute::StartResetPassword => match password_reset_enabled { + Some(true) => html! { }, + Some(false) => { App::dispatch_route(AppRoute::Login, link, is_admin, password_reset_enabled) } - } - AppRoute::FinishResetPassword(token) => html! { - if password_reset_enabled { - html! { - - } - } else { + + None => html! {}, + }, + AppRoute::FinishResetPassword(token) => match password_reset_enabled { + Some(true) => html! { }, + Some(false) => { App::dispatch_route(AppRoute::Login, link, is_admin, password_reset_enabled) } + None => html! {}, }, } } @@ -287,50 +283,48 @@ impl App { } } else { html!{} } } - + } else { html!{} } + } diff --git a/app/src/components/reset_password_step2.rs b/app/src/components/reset_password_step2.rs index a14b36b..c1cdeba 100644 --- a/app/src/components/reset_password_step2.rs +++ b/app/src/components/reset_password_step2.rs @@ -1,5 +1,5 @@ use crate::{ - components::router::AppRoute, + components::router::{AppRoute, NavButton}, infra::{ api::HostService, common_component::{CommonComponent, CommonComponentParts}, @@ -158,9 +158,17 @@ impl Component for ResetPasswordStep2Form { } (None, Some(e)) => { return html! { -
- {e.to_string() } -
+ <> +
+ {e.to_string() } +
+ + {"Back"} + + } } _ => (), diff --git a/server/src/infra/auth_service.rs b/server/src/infra/auth_service.rs index ce7bc1b..5dc0cc1 100644 --- a/server/src/infra/auth_service.rs +++ b/server/src/infra/auth_service.rs @@ -214,11 +214,15 @@ where let token = request .match_info() .get("token") - .ok_or_else(|| TcpError::BadRequest("Missing reset token".to_string()))?; + .ok_or_else(|| TcpError::BadRequest("Missing reset token".to_owned()))?; let user_id = data .backend_handler .get_user_id_for_password_reset_token(token) - .await?; + .await + .map_err(|e| { + debug!("Reset token error: {e:#}"); + TcpError::NotFoundError("Wrong or expired reset token".to_owned()) + })?; let _ = data .backend_handler .delete_password_reset_token(token) diff --git a/server/src/infra/tcp_server.rs b/server/src/infra/tcp_server.rs index c27846d..166b65e 100644 --- a/server/src/infra/tcp_server.rs +++ b/server/src/infra/tcp_server.rs @@ -37,6 +37,8 @@ pub enum TcpError { BadRequest(String), #[error("Internal server error: `{0}`")] InternalServerError(String), + #[error("Not found: `{0}`")] + NotFoundError(String), #[error("Unauthorized: `{0}`")] UnauthorizedError(String), } @@ -57,6 +59,7 @@ pub(crate) fn error_to_http_response(error: TcpError) -> HttpResponse { | DomainError::EntityNotFound(_) => HttpResponse::BadRequest(), }, TcpError::BadRequest(_) => HttpResponse::BadRequest(), + TcpError::NotFoundError(_) => HttpResponse::NotFound(), TcpError::InternalServerError(_) => HttpResponse::InternalServerError(), TcpError::UnauthorizedError(_) => HttpResponse::Unauthorized(), }