Prior to this commit 3 of the 4 parameters were not validated.
After this commit, the parameters are correctly validated.
Due to MODULES-2960 $autovacuum_scale_factor is validated as a float
but then is converted to a string to pass it to the value attribute
of postgresql_conf.
Due to an issue where console-services fails to complete about
2 requests after a restart of postgresql, let's go ahead and
restart the console-services service if we restart the postgresql
service.
If the console-services is not on the same node as postgresql then
set all_in_one_pe_install to false and console-services will not
be restarted.
In the past I've seen the console and puppetdb databases grow
much larger than expected and I have a hypothesis that this is
because the default 20% setting for autovacuum is too high for our
workload. So, there's a potential that changing this to 1%
might be too low and might reduce performance but it should
reduce disk usage and it can always be tuned upward if the
performance hit is too large, however, it is much more difficult
to reduce the size of a database after it has grown too large.
Basically, I'm erroring on the side of using less disk space and
hopefully less outages due to running out of disk space and we
can open a conversation on performance later if one needs to be had.
