anthrove/otter-space-sdk
Archived
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 10 Wiki Activity

BREAKING CHANGE: V2 of thr SDK #12

Merged
fenpaws merged 124 commits from develop/postgresql into main 2024-07-01 20:46:28 +00:00
Conversation 0 Commits 124 Files Changed 59 +33 -3
3 changed files with 33 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 768203ebd7 - Show all commits

2
internal/postgres/tag.go
View File

@ -69,7 +69,7 @@ func GetAllTagByTagsType(ctx context.Context, db *gorm.DB, tagType models.TagTyp
return nil, &otterError.EntityValidationFailed{Reason: "tagType cannot be empty"} return nil, &otterError.EntityValidationFailed{Reason: "tagType cannot be empty"}
} }
result := db.WithContext(ctx).Find(&tags).Where("tag_type = ?", tagType) result := db.WithContext(ctx).Model(&models.Tag{}).Where("tag_type = ?", tagType).Scan(&tags)
fenpaws marked this conversation as resolved Outdated
lennard.brinkhaus commented 2024-07-01 20:33:13 +00:00
Outdated
Review
Copy Link

please use Scan instead of Find if you have a Where clause.
Or if you use find, put the Filter into the find function. Also its best practice if you move the Find, Scan, Create, ... as last method.

please use Scan instead of Find if you have a Where clause. Or if you use find, put the Filter into the find function. Also its best practice if you move the Find, Scan, Create, ... as last method.
if result.Error != nil { if result.Error != nil {
if errors.Is(result.Error, gorm.ErrRecordNotFound) { if errors.Is(result.Error, gorm.ErrRecordNotFound) {

17
internal/postgres/tag_test.go
View File

@ -1050,6 +1050,21 @@ func TestGetAllTagByTagType(t *testing.T) {
}, },
} }
expectetResult := []models.Tag{
{
Name: "JayTheFerret",
Type: models.Character,
},
{
Name: "SoXX",
Type: models.Character,
},
{
Name: "Alphyron",
Type: models.Character,
},
}
for _, tag := range validTags { for _, tag := range validTags {
err = CreateTag(ctx, gormDB, models.AnthroveTagName(tag.Name), tag.Type) err = CreateTag(ctx, gormDB, models.AnthroveTagName(tag.Name), tag.Type)
if err != nil { if err != nil {
@ -1076,7 +1091,7 @@ func TestGetAllTagByTagType(t *testing.T) {
db: gormDB, db: gormDB,
tagType: models.Character, tagType: models.Character,
}, },
want: validTags, want: expectetResult,
wantErr: false, wantErr: false,
}, },
{ {

17
pkg/database/postgres_test.go
View File

@ -3174,6 +3174,21 @@ func Test_postgresqlConnection_GetAllTagsByTagType(t *testing.T) {
}, },
} }
expectetResult := []models.Tag{
{
Name: "JayTheFerret",
Type: models.Character,
},
{
Name: "SoXX",
Type: models.Character,
},
{
Name: "Alphyron",
Type: models.Character,
},
}
for _, tag := range validTags { for _, tag := range validTags {
err = postgres.CreateTag(ctx, gormDB, models.AnthroveTagName(tag.Name), tag.Type) err = postgres.CreateTag(ctx, gormDB, models.AnthroveTagName(tag.Name), tag.Type)
if err != nil { if err != nil {
@ -3198,7 +3213,7 @@ func Test_postgresqlConnection_GetAllTagsByTagType(t *testing.T) {
ctx: ctx, ctx: ctx,
tagType: models.Character, tagType: models.Character,
}, },
want: validTags, want: expectetResult,
wantErr: false, wantErr: false,
}, },
{ {